Switch file watcher to stop use polling; bump vscode to 1.66.0 #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auscompgeek
reviewed
Oct 12, 2023
pokey
force-pushed
the
pokey/switch-file-watcher-to-stop-use-polling
branch
from
111ebb6 to
319ac26
Compare
|
I bumped min version in this PR to match the legacy version that we test (1.66.0), as that version is over 1 year old, and per #1846, we're comfortable only supporting a year back, as users with older VSCode versions will just stop receiving Cursorless upgrades, which seems reasonable if they're on a very old VSCode version. Fwiw this PR requires version 1.64.0 to watch arbitrary paths |
pokey
changed the title
|
@AndreasArvidsson this one is ready to go from my perspective |
AndreasArvidsson
approved these changes
Oct 18, 2023
AndreasArvidsson
deleted the
pokey/switch-file-watcher-to-stop-use-polling
branch
fidgetingbits
pushed a commit
to fidgetingbits/cursorless
that referenced
this pull request
Nov 3, 2023
…rless-dev#1945) - Fixes cursorless-dev#1808 - Fixes cursorless-dev#1846 ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist