Move types dependency to dev dependencies #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@auscompgeek Any idea why there would be such a gigantic lockfile diff here? |
|
This diff does look pretty weird 🤔 |
|
Agreed. I was hoping one of you would have any ideas. The only thing I did was move the dependency and do a |
|
very odd—when I did a pnpm install locally, I got a tiny diff. I pushed it here. Maybe something strange with your local pnpm @AndreasArvidsson? |
auscompgeek
approved these changes
Oct 12, 2023
pokey
approved these changes
Oct 12, 2023
|
Could it be a version problem? |
|
That'd probably be it. Our corepack package manager version is pinned to an 8.x: Line 56 in 92b2112 |
|
Ah yeah you def want to be 8-series. They changed a bunch of stuff with v8 |
fidgetingbits
pushed a commit
to fidgetingbits/cursorless
that referenced
this pull request
Nov 3, 2023
## Checklist - [/] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [/] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [/] I have not broken the cheatsheet --------- Co-authored-by: Pokey Rule <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist