Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added join lines action #1901

Merged
merged 9 commits into from
Dec 6, 2023
Merged

Added join lines action #1901

merged 9 commits into from
Dec 6, 2023

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Sep 16, 2023

"join air"
"join block air"

Fixes #50

Checklist

@AndreasArvidsson AndreasArvidsson changed the title JoinLinesAction Added join lines action Sep 16, 2023
@AndreasArvidsson AndreasArvidsson marked this pull request as ready for review September 16, 2023 12:42
@AndreasArvidsson
Copy link
Member Author

@pokey poke!

@AndreasArvidsson
Copy link
Member Author

@pokey Nudge nudge!

@AndreasArvidsson
Copy link
Member Author

@pokey I added a test with an empty line in the middle

@AndreasArvidsson
Copy link
Member Author

@pokey Any more problems on this?

Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I made a slight tweak to impl that felt a bit clearer to me; took me a couple reads to figure out you were doing pairwise iteration. Feel free to merge if you're happy with my changes

@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit 740e3ef Dec 6, 2023
14 checks passed
@AndreasArvidsson AndreasArvidsson deleted the joinLinesAction branch December 6, 2023 17:04
cursorless-bot pushed a commit that referenced this pull request Dec 6, 2023
`"join air"`
`"join block air"`

Fixes #50

## Checklist

- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet

---------

Co-authored-by: Pokey Rule <[email protected]>
thetomcraig-aya pushed a commit to thetomcraig/cursorless that referenced this pull request Mar 27, 2024
`"join air"`
`"join block air"`

Fixes cursorless-dev#50

## Checklist

- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet

---------

Co-authored-by: Pokey Rule <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "join" action to join lines
2 participants