-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thicker hats #1809
thicker hats #1809
Conversation
Thicker hole; at low-res, the hole is a bit small but you can definitely still see that it has a hole in the middle. Overall, I am happy that it distinguishes itself from the default circle shape in two ways: hole in middle and ragged outside perimeter. |
Cool. How is it working in practice? |
For crosshairs.svg, I am wondering about whether to remove the interior hole, or just make it smaller. The closest shapes are wing, fox, ex, (
The new hole feels so much clearer, visually and mentally. Some of the hesitation that comes from looking at a tiny mess of pixels that I logically know is "hole" is gone. Time will tell, but the start is strong. |
I love to try this out, but I don't use either of those shapes yet. I'm particularly keen to try out a thicker ex. Do you plan to do more soon, or should I hack it in myself? Also, I'd like to discuss ways to add "hidden features", so we can land things like this promptly and with a low bar, so we can all play with them quietly. (I know you can do a local install, but I have lots of things I want to play with, and it's annoying to juggle a bunch of them.) |
I'll probably do ex in a few minutes. Then possibly frame, eye, wing, fox, curve.
I use this powershell script in the source hats folder to make it easy to change my hats. I just have to run the script and then do "window reload" command in VSCode. Note: powershell is cross platform, but you might have to install it on mac or Linux.
|
I am going to stop for a bit and gather feedback on what I've already done, including me using them for a while. |
xlink #288 |
It's quite easy to have secret settings in VSCode, so we could have a secret setting where you provide your own svg, keeping in mind the issues around our svg requirements which I believe are mentioned somewhere in the hat styling issue comments |
After some use, I'm still very pleased. |
@AndreasArvidsson asked for some curves at the central corners of the cross hat, especially to make it more distinct from a plus symbol, so I did that. |
some quick reactions from driving for a little bit:
|
@jmegner mind dropping a link to the software / website you're using to edit the hats? or are you just directly messing with the svg text? |
@pokey ...
Andreas also found the new cross confuse-able with a plus sign, so I will be going back to a pointed, star-like thing, but thicker.
I will try out some bigger holes for "hole". Can you provide a screenshot of what you are seeing and some details so I can try to reproduce your experienced appearance?
I started with InkScape but then went to free plan on https://app.svgator.com . However, I'm fiddling with a new "chip" hat and it is simple enough that text editing is practical. It might be possible to simplify frame, curve, and some others to nearly the same simplicity. chip:
I will try out some bigger holes for "hole".
Color and shape recognition would suffer. I would advise against it. We want as much foreground area and feature coarseness as possible while not sacrificing too much distinctness.
I will try something that is basically a thicker and filled in version of the original.
What hats are too similar to the new wing? |
@jmegner fwiw i passed along these new hats to the artist who made the originals, as a starting point for thicker hats. We'll see if he ends up having time to work on them, but he said he'd try to find some time Thanks for getting the ball rolling on this one. I think if nothing else, I'm convinced even after a day using them that thicker hats are a usability win |
In what ways are these thicker hats not ready for release (other than hole and wing)? |
No one really, but to me it's too indistinct and just looks like three blobs. I would like the different features to be more distinct if possible. |
Anything aesthetic needs to be reviewed by our artist, as I'm not really qualified. You can think of him as the "code owner" for all things aesthetic 😊 |
As an intense user of cursorless, I think you are qualified to have an opinion on hat usability, which is the most important part of the hat shapes. The hats are foremost objects for usability and accessibility. There is not much room for beauty at 8x6 pixels, and I think most users prefer usability (that's the biggest reason people disable certain hats). If this artist doesn't use cursorless and isn't aware of low-res shape/color recognition principles, I don't think they are in a good position to make the tradeoffs in hat design that best serve the users. |
Relatedly, are you open to a setting where the user can provide a path to a folder that has hat image overrides? I know that we need to be prudent with our setting count. |
Yeah we discussed this topic at length at the meet-up yesterday, and I think everyone was supportive of the idea, but there were some implementation details that we couldn't work out. Though I think we maybe got too caught up on the idea of allowing people to just have a directory with as many hats as they want with whatever names they want to support extra hats if they'd like. If we just wanted to support overrides for existing hats, it should be fairly straightforward. @josharian @AndreasArvidsson @phillco does that sound like a reasonable place to start given we couldn't figure out how to make the details work for arbitrary hats? Basically would just have a setting that specifies a path to an overrides dir, and anything in that dir whose name matches one of our hat names (with |
Sounds fine to me |
Sounds great. |
Okay, I like "distinct" in this context to mean easily distinguishable from others. Are you meaning it doesn't feel like a coherent, single shape? Can you share a screenshot of the wing you are seeing? It all looks very connected and one coherent thing to me. @AndreasArvidsson @pokey And I'd still like those screenshots of what you are seeing for hole and telling me some of your setting so I can try to reproduce it. |
Something like that. The shape isn't very well defined. |
|
I think cross looks really good like this. Will you attend the meet up later? We could do a screen share and test a few things during the meet up if you have the time? |
Yes, sounds good. |
To capture some notes from today's meeting:
|
@jmegner lmk when you're done with the hats and I'll start jamming with Matt. Thanks for all your hard work on this stuff! |
Ok cool. I saw that bullet point, but wasn't sure whether "getting to the point" meant we're already at that point, or if there was more you wanted to do before you considered us to be there. Will take it from here; thank you! |
Closing in favour of #1868. Thank you for kicking off this effort! 🙌 |
starting with thicker bolt
EDIT: cool, https://github.com/cursorless-dev/cursorless/pull/1809/files renders before and after