Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursorless enablement group page #1660

Merged
merged 71 commits into from
Nov 2, 2023
Merged

Conversation

pokey
Copy link
Member

@pokey pokey commented Jul 19, 2023

See deploy preview

  • Also adds support for mdx in our top-level cursorless-org package

Checklist

  • Add meta social tags
  • Use latest logo
  • Why is logo on social slow? And is it new logo?
  • Make prices clickable
  • document that sponsorship levels are yearly
  • [-] I have added tests
  • [-] I have updated the docs and cheatsheet
  • [-] I have not broken the cheatsheet

@pokey pokey force-pushed the pokey/cursorless-enablement-group-page branch from 1854ce0 to 8ae46c5 Compare July 19, 2023 13:30
@pokey pokey force-pushed the pokey/cursorless-enablement-group-page branch 2 times, most recently from 6e79274 to d78bb4e Compare July 19, 2023 15:18
@pokey pokey force-pushed the pokey/cursorless-enablement-group-page branch from d78bb4e to f78dc83 Compare July 19, 2023 15:21
@pokey pokey force-pushed the pokey/cursorless-enablement-group-page branch from 33e3929 to 26e7e7b Compare July 19, 2023 16:41
@pokey pokey force-pushed the pokey/cursorless-enablement-group-page branch from 26e7e7b to 47038bc Compare July 20, 2023 14:26
Copy link
Contributor

@F-Kunkle F-Kunkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey both of these edits look grat!

Copy link
Contributor

@F-Kunkle F-Kunkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like all of these edits and think they're an improvement! Reminder that GitHub is still a bit new to me so i'm hoping i'm approving the 5 edits I saw on this page in a fashion that works for you. Thx!

@pokey pokey marked this pull request as ready for review November 1, 2023 17:46
@pokey
Copy link
Member Author

pokey commented Nov 1, 2023

ok @AndreasArvidsson this one is good to go

@AndreasArvidsson
Copy link
Member

I had no idea that this concept was this far along. Do we need to talk about some aspects of this or do you just want to run this all yourself?

This doesn't look to good on firefox
image

@pokey
Copy link
Member Author

pokey commented Nov 2, 2023

There's a marketing guy who's been managing the whole thing; happy to chat tho if you want more detail on where things are

That's supposed to be cut off like that as an indication that you can scroll horizontally. I'll see if I can come up with another way to indicate that that's less confusing 🤔

@AndreasArvidsson
Copy link
Member

Gladly!

There is no scroll bar or carousel arrows. Not the most intuitive ux ;)

@pokey
Copy link
Member Author

pokey commented Nov 2, 2023

ok @AndreasArvidsson I decided to use your patented KISS system and just put them directly in the flow of the document 😄

@pokey pokey enabled auto-merge November 2, 2023 19:44
@pokey pokey added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit 962f64f Nov 2, 2023
13 checks passed
@pokey pokey deleted the pokey/cursorless-enablement-group-page branch November 2, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants