Make it easier to have unit tests in VSCode packages #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
commented
Jun 19, 2023
pokey
force-pushed
the
pokey/make-it-easier-to-have-unit-tests-in-vscode-packages
branch
from
9a6c0f3 to
40876ec
Compare
AndreasArvidsson
approved these changes
Jun 19, 2023
pokey
deleted the
pokey/make-it-easier-to-have-unit-tests-in-vscode-packages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new convention for tests that end with
.vscode.test.tsmust run within VSCode; other tests can be run as unit tests outside of VSCode. This makes it easier to add unit tests within packages such ascursorless-vscode. Just because a package is designed to be used with VSCode doesn't mean that all of its tests should have to be run within a VSCode context. It might (and should!) have support code that consists of pure functions with no dependencies.Checklist