Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theming] Overhaul Icon Generation #529

Merged
merged 58 commits into from
Nov 24, 2020
Merged

[Theming] Overhaul Icon Generation #529

Show file tree
Hide file tree
Changes from 53 commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
e91a13c
Remove deprecated icons (none in use, new major version required anyway)
michaeljaltamirano Nov 13, 2020
9b0bd46
Delete unused style file
michaeljaltamirano Nov 13, 2020
c48fa01
Rename propTypes, defaultProps, and inline prop name (raises dev cons…
michaeljaltamirano Nov 13, 2020
fde60a3
Remove icons from gitignore
michaeljaltamirano Nov 16, 2020
bd37b37
Fix path import resolution, recognize theme __type signature
michaeljaltamirano Nov 16, 2020
209e561
Add useIcon hook
michaeljaltamirano Nov 16, 2020
a95b21e
Commit new icons directory
michaeljaltamirano Nov 17, 2020
a1befe5
Commit shared-component/icon changes
michaeljaltamirano Nov 17, 2020
e118671
Delete src/svgs folder
michaeljaltamirano Nov 17, 2020
2d1cdff
Update prop spreading rules
michaeljaltamirano Nov 17, 2020
77c060a
Adjust src and stories
michaeljaltamirano Nov 17, 2020
a7ad3b1
Adjust svg build options
michaeljaltamirano Nov 17, 2020
d29e1bc
Push snapshot changes
michaeljaltamirano Nov 17, 2020
a9d1442
Bump svgr packages, removing CLI icon building steps (temporarily), a…
michaeljaltamirano Nov 17, 2020
1150ceb
Merge branch 'master' into poc/icons
michaeljaltamirano Nov 17, 2020
e9bb4a7
Update size snapshot
michaeljaltamirano Nov 17, 2020
3e20443
Remove SVGR icon generation scaffolding (no longer in use)
michaeljaltamirano Nov 17, 2020
eee2363
Remove MDX file, update Notes for Icons
michaeljaltamirano Nov 17, 2020
752f977
Remove icon TODOs
michaeljaltamirano Nov 17, 2020
006f827
use non-forked create-index
michaeljaltamirano Nov 17, 2020
7aaacef
Export icons as default to avoid auto-import namespace pollution, upd…
michaeljaltamirano Nov 17, 2020
a5d6969
Merge branch 'master' into poc/icons
michaeljaltamirano Nov 17, 2020
200202d
Fix storybook command
michaeljaltamirano Nov 17, 2020
76bf5ea
Write after build to avoid whitespace issue
michaeljaltamirano Nov 17, 2020
0ff0f5a
Fix serializing via Icon and useIcon setup
michaeljaltamirano Nov 17, 2020
a63d5c2
Delete the prettierignore
michaeljaltamirano Nov 18, 2020
6caba3d
Remove src/icons specific eslint rules
michaeljaltamirano Nov 18, 2020
1df8eee
Move formatting logic into create-index, run tsc after index is created
michaeljaltamirano Nov 18, 2020
2420e62
Update size snapshot and Icon JSDoc comment
michaeljaltamirano Nov 18, 2020
ab3212a
Fix casing issue with LockIcon
michaeljaltamirano Nov 18, 2020
18c5bff
Fix casing (again)
michaeljaltamirano Nov 18, 2020
7af9dd7
Remove unused postbuild step command
michaeljaltamirano Nov 18, 2020
232de34
Bump node version
michaeljaltamirano Nov 18, 2020
c54fc7e
Restore fill application in snapshots
michaeljaltamirano Nov 18, 2020
a810f2f
Merge branch 'master' into poc/icons
michaeljaltamirano Nov 18, 2020
6061ffb
Update svg mock mapping for jest
michaeljaltamirano Nov 18, 2020
e222486
Delete unused icon test
michaeljaltamirano Nov 18, 2020
0b46c3d
Reformat useIcon context comment
michaeljaltamirano Nov 18, 2020
d38d623
Update build .size-snapshot.json
michaeljaltamirano Nov 18, 2020
406dc6c
Reset icon story setup
michaeljaltamirano Nov 19, 2020
e403469
First pass of working Icon component without fill regression
michaeljaltamirano Nov 19, 2020
dc2391d
Simplify usage without cloneElement to be more straightforward
michaeljaltamirano Nov 19, 2020
257923c
Make arrow like our other icons
michaeljaltamirano Nov 19, 2020
e88ee59
Remove warning in rollup build step re: umd naming
michaeljaltamirano Nov 20, 2020
1d52678
Commit working overhaul, src/icons/test functionality WIP
michaeljaltamirano Nov 20, 2020
ba3550e
Temporarily modify src/icons/test
michaeljaltamirano Nov 20, 2020
8444b17
Commit change to prevent newline diff
michaeljaltamirano Nov 20, 2020
c30e964
No newline re-write, pt. 2
michaeljaltamirano Nov 20, 2020
8c47a3c
Fix casing for navIcons build step
michaeljaltamirano Nov 20, 2020
de7e988
Update icon svg test
michaeljaltamirano Nov 20, 2020
31ba633
Merge branch 'master' into poc/icons
michaeljaltamirano Nov 20, 2020
bbba415
Update heroku postbuild step (to avoid build error from earlier this …
michaeljaltamirano Nov 20, 2020
99eac0b
Update icons stories add an SVG description
michaeljaltamirano Nov 20, 2020
01a319f
Clean src/icons/**/svgs to ensure icon generation is consistent + we …
michaeljaltamirano Nov 21, 2020
3c287c4
Try postbuild step without icon generation, for fun
michaeljaltamirano Nov 21, 2020
b9dbe22
Merge branch 'master' into poc/icons
michaeljaltamirano Nov 23, 2020
6aec061
Merge branch 'master' into poc/icons
michaeljaltamirano Nov 24, 2020
cf2c604
Remove svgr/webpack, fix Icon prop type, simplify storybook webpack c…
michaeljaltamirano Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
15 changes: 8 additions & 7 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
},
"settings": {
"import/resolver": {
"node": {},
"webpack": {
"config": "./.storybook/webpack.config.js"
}
Expand Down Expand Up @@ -54,7 +55,7 @@
"no-underscore-dangle": [
"warn",
{
"allow": ["__isProxy"]
"allow": ["__isProxy", "__type"]
}
],
"no-use-before-define": "off",
Expand Down Expand Up @@ -123,20 +124,20 @@
{
"files": ["*.tsx"],
"rules": {
"react/prop-types": "off"
"react/prop-types": "off",
"react/jsx-props-no-spreading": "off"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have full type coverage in radiance-ui/src 🥳 So we can turn this off for TS files.

}
},
{
"files": ["stories/**/*.{js,ts,tsx}"],
"files": ["src/icons/**/svgs/index.tsx"],
"rules": {
"no-alert": "off"
"prettier/prettier": "off"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index.tsx file generated by @svgr/cli lacks a newline. Without this, the respective files will always appear to have been modified, which is annoying. 🙃

}
},
{
"files": ["src/icons/**"],
"files": ["stories/**/*.{js,ts,tsx}"],
"rules": {
"import/extensions": "off",
"react/jsx-props-no-spreading": "off"
"no-alert": "off"
}
}
]
Expand Down
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ typings/
# build files
dist/
lib/
src/icons/
.out

# JetBrains
Expand Down
7 changes: 1 addition & 6 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1 @@
src/svgs/deprecated/index.js
src/svgs/emojis/index.js
src/svgs/glyphs/index.js
src/svgs/icons/index.js
src/svgs/logos/index.js
src/svgs/navIcons/index.js
src/icons/**/svgs/index.tsx
Loading