-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @svgr/cli from 4.3.3 to 5.4.0 #230
Conversation
7194b46
to
720a9b6
Compare
720a9b6
to
b7146be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to double-check the breaking changes (default behavior is different).
9c64f53
to
3b4125b
Compare
4656179
to
1d26c6a
Compare
1d26c6a
to
e0f757d
Compare
e0f757d
to
3461bd9
Compare
Bumps [@svgr/cli](https://github.com/gregberge/svgr) from 4.3.3 to 5.4.0. - [Release notes](https://github.com/gregberge/svgr/releases) - [Changelog](https://github.com/gregberge/svgr/blob/master/CHANGELOG.md) - [Commits](gregberge/svgr@v4.3.3...v5.4.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
3461bd9
to
635e854
Compare
@dependabot recreate |
Bumps [@svgr/cli](https://github.com/gregberge/svgr) from 4.3.3 to 5.4.0. - [Release notes](https://github.com/gregberge/svgr/releases) - [Changelog](https://github.com/gregberge/svgr/blob/master/CHANGELOG.md) - [Commits](gregberge/svgr@v4.3.3...v5.4.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
5165e36
to
b10d4e8
Compare
…urology/radiance-ui into dependabot/npm_and_yarn/svgr/cli-5.4.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty much good to merge, but not approving for a few reasons:
- v5 of the CLI drops support for node 8. Our package.json reports that we support it--we will probably enforce
>10
soon enough, at which point it will be merge-safe. - v5 also generates a custom
index.js
when using-d/--out-dir
. The problem is that as it hits new directories it overwrites what it previously populates, even if we populate via one script command pulling in everything fromsrc/svgs/**
.- To work around this, we just remove the file it automatically generates. It's a little hacky but I could not find a way to suppress it easily via the SVGR CLI, and it appears to be the only instance we're using svgr this way.
A newer version of @svgr/cli exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Closing, updated in #529 |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps @svgr/cli from 4.3.3 to 5.4.0.
Release notes
Sourced from @svgr/cli's releases.
Changelog
Sourced from @svgr/cli's changelog.
Commits
e9c9d2f
v5.4.06179cd9
Merge pull request #445 from gregberge/cli-options-in-config8c6f7b5
style: prettier formata23a186
feat(cli): make all CLI options available in configd0b59cd
chore(deps): upgrade (#444)1b56b85
feat: addForeignObject
support for react native (#430)7c46ad7
fix(cli): fix index generation (#443)706df21
docs(readme): add link to VSCode extension (#434)a6de2da
fix: wrap svg component directly with memo/forwardRef (#440) (#441)f30bb85
v5.3.1Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: