Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @svgr/cli from 4.3.3 to 5.4.0 #230

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Apr 28, 2020

Bumps @svgr/cli from 4.3.3 to 5.4.0.

Release notes

Sourced from @svgr/cli's releases.

v5.4.0

Bug Fixes

Features

  • add ForeignObject support for react native (#430) (1b56b85)
  • cli: make all CLI options available in config (a23a186), closes #431 #437

v5.3.1

Bug Fixes

v5.3.0

Bug Fixes

  • cli: remove confusion between {keep,ignore}-existing (#413) (c5430f9), closes #390
  • parcel-plugin: support "parcel" and "parcel-bundler" (853db4e), closes #410
  • svgo: support any SVGO config format (#412) (f2b2367), closes #400

Features

v5.2.0

Bug Fixes

  • verify that svgoConfig.plugins is an array (#397) (88110b6)

Features

  • parcel-plugin: replace parcel-bundler with parcel (#387) (d09bcd5)

v5.1.0

... (truncated)
Changelog

Sourced from @svgr/cli's changelog.

5.4.0 (2020-04-27)

Bug Fixes

Features

  • add ForeignObject support for react native (#430) (1b56b85)
  • cli: make all CLI options available in config (a23a186), closes #431 #437

5.3.1 (2020-04-05)

Bug Fixes

5.3.0 (2020-03-22)

Bug Fixes

  • cli: remove confusion between {keep,ignore}-existing (#413) (c5430f9), closes #390
  • parcel-plugin: support "parcel" and "parcel-bundler" (853db4e), closes #410
  • svgo: support any SVGO config format (#412) (f2b2367), closes #400

Features

5.2.0 (2020-02-23)

... (truncated)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Apr 28, 2020
@snags88 snags88 had a problem deploying to curology-radiance-pr-230 April 28, 2020 06:03 Failure
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/svgr/cli-5.4.0 branch 2 times, most recently from 7194b46 to 720a9b6 Compare June 25, 2020 15:10
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/svgr/cli-5.4.0 branch from 720a9b6 to b7146be Compare July 23, 2020 17:12
Copy link
Contributor

@michaeljaltamirano michaeljaltamirano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to double-check the breaking changes (default behavior is different).

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/svgr/cli-5.4.0 branch 2 times, most recently from 9c64f53 to 3b4125b Compare August 24, 2020 19:00
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/svgr/cli-5.4.0 branch 13 times, most recently from 4656179 to 1d26c6a Compare September 14, 2020 22:06
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/svgr/cli-5.4.0 branch from 1d26c6a to e0f757d Compare September 17, 2020 15:03
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/svgr/cli-5.4.0 branch from e0f757d to 3461bd9 Compare October 7, 2020 22:20
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/svgr/cli-5.4.0 branch from 3461bd9 to 635e854 Compare October 20, 2020 21:36
@michaeljaltamirano
Copy link
Contributor

@dependabot recreate

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/svgr/cli-5.4.0 branch from 5165e36 to b10d4e8 Compare October 23, 2020 08:44
Copy link
Contributor

@michaeljaltamirano michaeljaltamirano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty much good to merge, but not approving for a few reasons:

  1. v5 of the CLI drops support for node 8. Our package.json reports that we support it--we will probably enforce >10 soon enough, at which point it will be merge-safe.
  2. v5 also generates a custom index.js when using -d/--out-dir. The problem is that as it hits new directories it overwrites what it previously populates, even if we populate via one script command pulling in everything from src/svgs/**.
    • To work around this, we just remove the file it automatically generates. It's a little hacky but I could not find a way to suppress it easily via the SVGR CLI, and it appears to be the only instance we're using svgr this way.

@dependabot-preview
Copy link
Contributor Author

A newer version of @svgr/cli exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@michaeljaltamirano
Copy link
Contributor

Closing, updated in #529

@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/svgr/cli-5.4.0 branch November 24, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants