feat: allow specifying a hook with removeHook()
#1054
Merged
+143
−54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request implements an optional second argument to
removeHook()
to allow specifying the hook function to remove.Background & Context
Currently you can only pop hooks off the stack.
It’s a pretty straight-forward implementation and non-breaking change to allow for specifying the hook to remove.
Because
DOMPurify
’s hooks are global it is otherwise difficult to write code with multiple paths that may be adding hooks and tidying up after themselves. Now it can be trivially written like:Tasks