Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(EmptyState): update styles using container queries #5287

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

HeartSquared
Copy link
Contributor

@HeartSquared HeartSquared commented Nov 18, 2024

Why

The recent changes fixed an overflow issue with EmptyState, but accidentally introduced image shrinking in its place.
image

What

  • Update EmptyState styles to respond using container queries
  • Add extra visual tests for container breakpoints
  • Deprecate layoutContext prop as it no longer does anything
  • Created a new StickerSheet component using CSS grid as container queries inside a table do not respond well
    • StickerSheet: Rename heading prop to title
    • StickerSheet: Add headers prop - replaces usage of StickerSheet.Header
    • StickerSheetRow: Rename rowTitle to header
  • Deleted .spec file as the tests are not useful/covered by Storybook tests

@HeartSquared HeartSquared requested a review from a team as a code owner November 18, 2024 02:59
Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: 82142ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 18, 2024

✨ Here is your branch preview! ✨

Last updated for commit 82142ef: fix(EmptyState): fix styles to work on FF and Safari

Copy link
Contributor

@mcwinter07 mcwinter07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty state change looks pretty good outside of the few little comments. Love the sticker sheet componentry moving away from the a table 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants