-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass at containerizing unit tests #35
base: main
Are you sure you want to change the base?
Conversation
Run `docker-compose build` to try it out. We should probabaly create a separate GitHub Actions workflow to run the tests so we can have that as a separate check that runs prior to the deploy workflow. Another benefit of this approach is that we can be much more liberal with the triggers for the tests workflow (i.e. any push).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine. I have found a way to integrate checkstyle into eclipse and have been fixing some indenting issues using that. I don't know if we'll ever come to a consensus on style preferences such as the use of tabs vs. spaces, number of spaces for indent, etc. But hopefully review changes won't be changing changestyle preferences that I'm using.
Thanks @fereira. Were you able to run the tests outside of the containers (your usual routine) when on this branch as well? I have no style preference when it comes to Java beyond consistency and will follow your lead. I noticed you included a .checkstyle in your last PR. Does that provide everything needed to ensure consistency if integrate checkstyle with my IDE? |
I haven't actually tried running the tests yet. I'll do that when I go upstairs in about 15 minutes. The .checkstyle is only for eclipse integration. The google_check.xml file which defines the styles criteria is built into a jar file and can't be edited. I had to copy it to an external file which I've modified a bit. It's pretty strict and I don't always agree with some of the changes it wants to make. I can provide a copy but it configuring it with the eclipse plugin isn't automatic. |
Ah...good to know. If you can share it when you get a chance, that would be great and then I'll look into integrations on my end. |
I have tested this with and without a container. All tests pass as long as the buildDir is set to "." |
Thanks @fereira. I have |
What is the status of this PR? It includes changes to the Configuration listener that I also need to modify for #26 |
I still consider it a draft until we have a separate GA workflow for tests. You should proceed freely with your PR to address #26 whenever you're ready. |
Run
docker-compose build
to try it out.We should probably create a separate GitHub Actions workflow to run the
tests so we can have that as a separate check that runs prior to the
deploy workflow. Another benefit of this approach is that we can be much
more liberal with the triggers for the tests workflow (i.e. any push).