Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DACCESS-360 - DRY up simple search param handling logic #2192

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

chrisrlc
Copy link
Contributor

@chrisrlc chrisrlc commented Dec 4, 2024

Summary: Reuses search param handling logic in SearchBuilder from advanced search for simple search, cleans up unused search param handling logic from CornellCatalog#index, fixes a couple adjacent bugs. More details:

In simple search:

TODO:

  • Maybe consider moving code out of SearchBuilder into separate QueryBuilder object? Will wait until removing prefix operators from bento search, since then it'll be more necessary to have reusable logic outside SearchBuilder.

@chrisrlc chrisrlc force-pushed the DACCESS-360-simple branch 2 times, most recently from 229319e to c739368 Compare December 5, 2024 21:57
@chrisrlc chrisrlc changed the base branch from DACCESS-360 to dev December 5, 2024 21:57
@chrisrlc chrisrlc force-pushed the DACCESS-360-simple branch 6 times, most recently from aa5075e to 95441d6 Compare January 9, 2025 15:11
@chrisrlc chrisrlc marked this pull request as ready for review January 9, 2025 15:39
@chrisrlc chrisrlc requested review from mhk33 and JeremyDuncan January 9, 2025 15:39
@chrisrlc chrisrlc changed the title DACCESS-360 - simple search WIP DACCESS-360 - simple search cleanuo Jan 9, 2025
@chrisrlc chrisrlc changed the title DACCESS-360 - simple search cleanuo DACCESS-360 - DRY up simple search param handling logic Jan 9, 2025
@JeremyDuncan
Copy link
Contributor

Wow lots of cleanup going on here! I pulled this and everything seems to work on my side.

@chrisrlc chrisrlc force-pushed the DACCESS-360-simple branch from 95441d6 to c93977e Compare January 9, 2025 20:15
@chrisrlc chrisrlc merged commit af158d0 into dev Jan 9, 2025
2 checks passed
@chrisrlc chrisrlc deleted the DACCESS-360-simple branch January 10, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants