Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace JUnit Jupiter with AssertJ #83

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Jan 31, 2025

⚡️ What's your motivation?

As a JUnit Platform Engine, Cucumber does not need JUnit Jupiter. It was included as a dependency to allow users to use Assertions. This is better done with AssertJ.

🏷️ What kind of change is this?

  • 📖 Documentation (improvements without changing code)

To be merged once cucumber/cucumber-jvm#2969 is released.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

As a JUnit Platform Engine, Cucumber does not need JUnit Jupiter. It was
included as a dependency to allow users to use Assertions. This is
better done with AssertJ.
Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for cucumber-website-preview ready!

Name Link
🔨 Latest commit 4339b76
🔍 Latest deploy log https://app.netlify.com/sites/cucumber-website-preview/deploys/679cefd61e5fe10008f9438f
😎 Deploy Preview https://deploy-preview-83--cucumber-website-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mpkorstanje mpkorstanje merged commit bb7e8ce into main Feb 2, 2025
5 checks passed
@mpkorstanje mpkorstanje deleted the replace-jupiter-with-assertj branch February 2, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants