Support rails 7.1 #575
Merged
Support rails 7.1 #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes ``` DEPRECATION WARNING: Setting action_dispatch.show_exceptions to false is deprecated. Set to :none instead. (called from call at /home/runner/work/cucumber-rails/cucumber-rails/lib/cucumber/rails/action_dispatch.rb:14) ```
Rails 7.1 introduces a new "Raise error on missing only unless" feature (see rails/rails#43487). The new feature is enabled by default. I rewrote the auto-generated code in feature specs to comply to the new rule.
4 tasks
olleolleolle
approved these changes
Oct 12, 2023
|
Can we add a changelog entry for this please as it's quite a big change @mgrunberg |
|
@luke-hill is #578 enough? I can change the message content if not. Also, would you consider releasing 3.0.0.rc.2? |
|
I'm looking to release v3 proper soon. We got about 1/2 to 2/3rds of the stuff in the rc1 release. There was only 2 big things I wanted to do else. One is on a branch I asked a couple of people to look at. Also I want to try leave the rc1 out for a bit to ensure nothing is completely goosed there. |
|
@luke-hill is now a good time for 3.0.0.rc.2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Use symbols to set
show_exceptionsin Rails 7.1+ and run test against Rails 7.1⚡️ What's your motivation?
I get a deprecation warning about the usage of a boolean with
show_exceptions🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.