Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update messages and dependants (major) #2928

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(deps): update messages and dependants (major) #2928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e88e07d
fix(deps): update messages and dependants
renovate[bot] Jan 29, 2025
d6c7ecb
fix: corrected renovate for #2928
Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cucumber-bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
<properties>
<ci-environment.version>10.0.1</ci-environment.version>
<cucumber-expressions.version>18.0.1</cucumber-expressions.version>
<gherkin.version>28.0.0</gherkin.version>
<gherkin.version>31.0.0</gherkin.version>
<html-formatter.version>21.7.0</html-formatter.version>
<junit-xml-formatter.version>0.5.0</junit-xml-formatter.version>
<messages.version>24.1.0</messages.version>
<messages.version>27.1.0</messages.version>
<query.version>12.2.0</query.version>
<tag-expressions.version>6.1.2</tag-expressions.version>
<testng-xml-formatter.version>0.2.0</testng-xml-formatter.version>
Expand Down
2 changes: 1 addition & 1 deletion cucumber-core/src/main/java/io/cucumber/core/runner/CachingGlue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ private void emitHook(CoreHookDefinition coreHook) {
coreHook.getDefinitionLocation()
.map(this::createSourceReference)
.orElseGet(this::emptySourceReference),
coreHook.getTagExpression());
coreHook.getTagExpression(), null);
bus.send(Envelope.of(messagesHook));
}

Expand Down
3 changes: 2 additions & 1 deletion cucumber-core/src/main/java/io/cucumber/core/runner/TestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@ private void emitTestCaseMessage(EventBus bus) {
getTestSteps()
.stream()
.map(this::createTestStep)
.collect(toList())));
.collect(toList()),
null));
bus.send(envelope);
}

Expand Down
3 changes: 3 additions & 0 deletions cucumber-core/src/main/java/io/cucumber/core/runner/TestCaseState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ public void attach(byte[] data, String mediaType, String name) {
null,
testExecutionId.toString(),
currentTestStepId.toString(),
null,
null)));
}

Expand All @@ -98,6 +99,7 @@ public void attach(String data, String mediaType, String name) {
null,
testExecutionId.toString(),
currentTestStepId.toString(),
null,
null)));
}

Expand All @@ -113,6 +115,7 @@ public void log(String text) {
null,
testExecutionId.toString(),
currentTestStepId.toString(),
null,
null)));
}

Expand Down
4 changes: 2 additions & 2 deletions cucumber-core/src/main/java/io/cucumber/core/runtime/CucumberExecutionContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ private void emitTestRunStarted() {
log.debug(() -> "Sending run test started event");
start = bus.getInstant();
bus.send(new TestRunStarted(start));
bus.send(Envelope.of(new io.cucumber.messages.types.TestRunStarted(toMessage(start))));
bus.send(Envelope.of(new io.cucumber.messages.types.TestRunStarted(toMessage(start), null)));
}

public void runBeforeAllHooks() {
Expand Down Expand Up @@ -120,7 +120,7 @@ private void emitTestRunFinished(Throwable exception) {
exception != null ? exception.getMessage() : null,
exception == null && exitStatus.isSuccess(),
toMessage(instant),
exception == null ? null : toMessage(exception));
exception == null ? null : toMessage(exception), null);
bus.send(Envelope.of(testRunFinished));
}

Expand Down
10 changes: 5 additions & 5 deletions cucumber-core/src/test/java/io/cucumber/core/plugin/HtmlFormatterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ void writes_index_html() throws Throwable {
EventBus bus = new TimeServiceEventBus(Clock.systemUTC(), UUID::randomUUID);
formatter.setEventPublisher(bus);

TestRunStarted testRunStarted = new TestRunStarted(new Timestamp(10L, 0L));
TestRunStarted testRunStarted = new TestRunStarted(new Timestamp(10L, 0L), null);
bus.send(Envelope.of(testRunStarted));

TestRunFinished testRunFinished = new TestRunFinished(null, true, new Timestamp(15L, 0L), null);
TestRunFinished testRunFinished = new TestRunFinished(null, true, new Timestamp(15L, 0L), null, null);
bus.send(Envelope.of(testRunFinished));

assertEquals("[" +
Expand All @@ -55,7 +55,7 @@ void ignores_step_definitions() throws Throwable {
EventBus bus = new TimeServiceEventBus(Clock.systemUTC(), UUID::randomUUID);
formatter.setEventPublisher(bus);

TestRunStarted testRunStarted = new TestRunStarted(new Timestamp(10L, 0L));
TestRunStarted testRunStarted = new TestRunStarted(new Timestamp(10L, 0L), null);
bus.send(Envelope.of(testRunStarted));

StepDefinition stepDefinition = new StepDefinition(
Expand All @@ -67,7 +67,7 @@ void ignores_step_definitions() throws Throwable {
Hook hook = new Hook("",
null,
SourceReference.of("https://example.com"),
null);
null, null);
bus.send(Envelope.of(hook));

// public ParameterType(String name, List<String> regularExpressions,
Expand All @@ -86,7 +86,7 @@ void ignores_step_definitions() throws Throwable {
null,
true,
new Timestamp(15L, 0L),
null);
null, null);
bus.send(Envelope.of(testRunFinished));

assertEquals("[" +
Expand Down
4 changes: 2 additions & 2 deletions cucumber-core/src/test/java/io/cucumber/core/plugin/JUnitFormatterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ void writes_report_xml() {
EventBus bus = new TimeServiceEventBus(Clock.systemUTC(), UUID::randomUUID);
formatter.setEventPublisher(bus);

TestRunStarted testRunStarted = new TestRunStarted(new Timestamp(10L, 0L));
TestRunStarted testRunStarted = new TestRunStarted(new Timestamp(10L, 0L), null);
bus.send(Envelope.of(testRunStarted));

TestRunFinished testRunFinished = new TestRunFinished(null, true, new Timestamp(15L, 0L), null);
TestRunFinished testRunFinished = new TestRunFinished(null, true, new Timestamp(15L, 0L), null, null);
bus.send(Envelope.of(testRunFinished));

assertThat(bytes, bytes(equalTo("" +
Expand Down
4 changes: 2 additions & 2 deletions cucumber-core/src/test/java/io/cucumber/core/plugin/MessageFormatterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ void test() throws JSONException {
EventBus bus = new TimeServiceEventBus(Clock.systemUTC(), UUID::randomUUID);
formatter.setEventPublisher(bus);

TestRunStarted testRunStarted = new TestRunStarted(new Timestamp(10L, 0L));
TestRunStarted testRunStarted = new TestRunStarted(new Timestamp(10L, 0L), null);
bus.send(Envelope.of(testRunStarted));

TestRunFinished testRunFinished = new TestRunFinished(null, true, new Timestamp(15L, 0L), null);
TestRunFinished testRunFinished = new TestRunFinished(null, true, new Timestamp(15L, 0L), null, null);
bus.send(Envelope.of(testRunFinished));

String ndjson = new String(bytes.toByteArray(), UTF_8);
Expand Down
4 changes: 2 additions & 2 deletions cucumber-core/src/test/java/io/cucumber/core/plugin/NoPublishFormatterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ public void should_print_banner() throws UnsupportedEncodingException {
noPublishFormatter.setMonochrome(true);
noPublishFormatter.setEventPublisher(bus);

bus.send(Envelope.of(new TestRunStarted(new Timestamp(0L, 0L))));
bus.send(Envelope.of(new TestRunFinished(null, true, new Timestamp(0L, 0L), null)));
bus.send(Envelope.of(new TestRunStarted(new Timestamp(0L, 0L), null)));
bus.send(Envelope.of(new TestRunFinished(null, true, new Timestamp(0L, 0L), null, null)));

assertThat(bytes, bytes(equalTo("" +
"┌───────────────────────────────────────────────────────────────────────────────────┐\n" +
Expand Down
3 changes: 2 additions & 1 deletion cucumber-core/src/test/java/io/cucumber/core/plugin/PluginFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,8 @@ public void fakeTestRunEvents() {
}
if (envelopeHandler != null) {
envelopeHandler.receive(
Envelope.of(new io.cucumber.messages.types.TestRunFinished("done", false, toMessage(now()), null)));
Envelope.of(
new io.cucumber.messages.types.TestRunFinished("done", false, toMessage(now()), null, null)));
}
}

Expand Down
4 changes: 2 additions & 2 deletions cucumber-core/src/test/java/io/cucumber/core/plugin/TestNGFormatterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ void writes_report_xml() {
EventBus bus = new TimeServiceEventBus(Clock.systemUTC(), UUID::randomUUID);
formatter.setEventPublisher(bus);

TestRunStarted testRunStarted = new TestRunStarted(new Timestamp(10L, 0L));
TestRunStarted testRunStarted = new TestRunStarted(new Timestamp(10L, 0L), null);
bus.send(Envelope.of(testRunStarted));

TestRunFinished testRunFinished = new TestRunFinished(null, true, new Timestamp(15L, 0L), null);
TestRunFinished testRunFinished = new TestRunFinished(null, true, new Timestamp(15L, 0L), null, null);
bus.send(Envelope.of(testRunFinished));

assertThat(bytes, bytes(equalTo("" +
Expand Down