Skip to content

Commit

Permalink
Correctly report error in publish plugin (#2454)
Browse files Browse the repository at this point in the history
Co-authored-by: harcop <[email protected]>
  • Loading branch information
davidjgoss and harcop authored Dec 10, 2024
1 parent 42483a3 commit 6e84e1d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
Please see [CONTRIBUTING.md](./CONTRIBUTING.md) on how to contribute to Cucumber.

## [Unreleased]
### Fixed
- Correctly report error in publish plugin ([#2454](https://github.com/cucumber/cucumber-js/pull/2454))

## [11.1.0] - 2024-11-17
### Added
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@
"Ted de Koning",
"temyers <[email protected]>",
"Tim Perry <[email protected]>",
"Toluwap (https://github.com/harcop)",
"Tom V <[email protected]>",
"Tomer Ben-Rachel <[email protected]>",
"Tristan Dunn <[email protected]>",
Expand Down
6 changes: 5 additions & 1 deletion src/publish/http_stream.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ export default class HttpStream extends Transform {
{},
(err2, res2) => {
if (doesHaveValue(err2)) return callback(err2)
this.emitErrorUnlessHttp2xx(res2, this.url, this.method)
this.emitErrorUnlessHttp2xx(
res2,
res1.headers.location,
'PUT'
)
callback()
}
)
Expand Down

0 comments on commit 6e84e1d

Please sign in to comment.