Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt at better modularity of parsing, w/r/t paths #192

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

susan-garry
Copy link
Contributor

This is an attempt to delegate more of the parsing of GFA path to gfaline.rs, along with other GFA lines, as opposed to parse.rs.

Because gfaline::Path stores references to strings and parsing of paths must be deferred until after steps are parsed, parse.rs still stores entire path lines to be parsed later, but now makes use of gfaline::parse_line much in the same way that it already did for links. Parts of the code are now more elegant, parts of them less so, and I think the only thing this really accomplished is satisfying the compiler's desire that all fields of gfaline::Path are read from.

@susan-garry susan-garry merged commit de1e3e8 into main Oct 2, 2024
12 checks passed
@susan-garry susan-garry deleted the better-path-parsing branch October 2, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant