FlatGFA: Hand-rolled GFA parser #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8b62c4c. Somehow, this was actually slower (and added an `unsafe`)!
This is the last piece!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next bottleneck in GFA parsing was the external rs-gfa library. I replaced this with a hand-rolled one.
Using the same measurement setup as #153:
So that's another 1.9x and 1.5x speedup over the last set of optimizations, for a total of 4x speedup over the first version.
It's clear that the bottleneck now is in the
memcpying to the destination files, which is also avoidable (with some compromises).