-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A flattened binary format for GFAs #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now dynamically check that these values are correct when reading out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I've been meaning to sketch for a long time, and finally hacked together a prototype. It is a Rust implementation of a flattened format for representing GFA data.
This MVP contains an in-memory format and some initial evidence that an on-disk binary file format is achievable without too much more work (by heavily relying on the zerocopy crate and a bunch of flat representation trickery). The prototype includes a byte-exact round-tripper for text GFA files (exploiting the rs-gfa crate for parsing and our own hand-rolled pretty-printer). The next steps are to finish off the reading and writing of binary files, and then to try implementing basic algorithms on top of this representation.
I will have more to say/write about this elsewhere when I get time, but though building this proof of concept, I am now hopeful that there is a path forward here to implement an interesting, flexible zero-copy binary format. And I suspect it will be fast.