-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gen config #439
Gen config #439
Conversation
┌─ tests/errors/binding/main-param.fil:2:6 | ||
│ | ||
2 │ comp main[A]<'G:1>() -> () { | ||
│ ^^^^ `main' requires at least 1 parameters but 0 were provided |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we improve the error message for this case and provide some extra guidance on how to parameterize main
because that is different from other components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was resolved but not actually addressed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some more info to the error message in the code? Do you mean to add more than this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the change. I meant we should say something like: "main
is a special external component. Parameterizing it correctly requires using the the parameter file/cmdline arguments"
Some suggestions to improve the error messages and question about new tests. Also, tests should ideally go in the |
As far as I can tell these are all in |
error: Incorrect parameter bindings provided to top-level component main | ||
= Parameter bindings should be provided via the `--bindings` flag in a `.toml` file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's here (not sure why it wasn't showing before) @rachitnigam
Adds the ability to configure compilation parameters through a config file.
The user provides a toml file as follows:
to override the
globals.conf
element ofdef.fil
.The user can also provide parameters to the
main
component by doing the following: