More lenient dtype support #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwhite
added
array api
xarray-integration
tomwhite
force-pushed
the
more-lenient-dtype-support
branch
from
966181d to
efc2e37
Compare
thodson-usgs
pushed a commit
to thodson-usgs/cubed
that referenced
this pull request
Oct 24, 2024
* Allow `bool` in `sum` and `prod` * Make dtype checking more lenient in case of 'all'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some array API implementations are more lenient in the dtypes they allow for certain operations - e.g.
sumcan be used on arrays ofbool(with return typeint64). The array API doesn't rule out this behaviour - it's just not a part of the spec.This is needed to improve Xarray integration, see cubed-dev/cubed-xarray#8