Skip to content

Run CI against upstream cubed and xarray #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Run CI against upstream cubed and xarray #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d82ad56
Run CI against upstream cubed and xarray
tomwhite Feb 6, 2025
5e5f08a
Fixes following xarray upstream improvements
tomwhite Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ jobs:
run: |
uv pip install --system '.'
uv pip install --system '.[test]'
uv pip install --system 'cubed @ git+https://github.com/cubed-dev/cubed.git' 'xarray @ git+https://github.com/pydata/xarray.git'

- name: Running Tests
run: |
Expand Down
3 changes: 0 additions & 3 deletions cubed_xarray/tests/test_xarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ def test_repr(self):
)
assert expected == repr(self.lazy_var)

@pytest.mark.xfail(reason="duck array ops problem in xarray")
def test_pickle(self):
# Test that pickling/unpickling does not convert the cubed
# backend to numpy
Expand Down Expand Up @@ -324,7 +323,6 @@ def test_chunk(self) -> None:

assert rechunked.chunksizes == expected_chunksizes

@pytest.mark.xfail(reason="cubed rechunk bug")
def test_rechunk(self):
chunked = self.eager_array.chunk({"x": 2}).chunk(
{"y": 2}, chunked_array_type="cubed"
Expand Down Expand Up @@ -456,7 +454,6 @@ def test_duplicate_dims(self):
assert chunked_array.chunks == ((2, 2), (2, 2))
assert chunked_array.chunksizes == {"x": (2, 2)}

@pytest.mark.xfail(reason="duck array ops problem in xarray")
def test_stack(self):
data = cubed.random.random(size=(2, 3, 4), chunks=(1, 3, 4))
arr = DataArray(data, dims=("w", "x", "y"))
Expand Down