feat: Support casting Utf8 to Interval
#29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cast string to interval * cast string to interval * unit tests * fix * update * code clean * update unit tests and align_interval_parts * fix ut * make clippy happy * Update arrow-cast/src/parse.rs Co-authored-by: Raphael Taylor-Davies <[email protected]> * change return types of calculate_from_part and fix bug of align_interval_parts * make clippy happy * remote useless overflow check * remove the "convert to higher units" logic --------- Co-authored-by: Raphael Taylor-Davies <[email protected]>
MazterQyou
force-pushed
the
cubesql-cast-utf8-to-interval
branch
2 times, most recently
from
aa79de7 to
cade622
Compare
MazterQyou
force-pushed
the
cubesql-cast-utf8-to-interval
branch
3 times, most recently
from
f78d269 to
0220bc1
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## cubesql-v11.1.0 #29 +/- ##
===================================================
- Coverage 82.85% 82.76% -0.10%
===================================================
Files 190 190
Lines 55023 55351 +328
===================================================
+ Hits 45592 45811 +219
- Misses 9431 9540 +109 ☔ View full report in Codecov by Sentry. |
MazterQyou
force-pushed
the
cubesql-cast-utf8-to-interval
branch
from
0220bc1 to
f4c88de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks upstream commits to add support for
Utf8toIntervalcasting.It also fixes a few issues with CI:
Cargo.tomlto pass CI for packages withoutCargo.lockpacked_simdcrate to a buildable one