Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix BE bookmark deletion.
Right here the
.splice
method is being used with theindexOf
operator. The issue is thatindexOf
returns-1
if the post is not found in the user’s saved posts. But splice will treat-1
as the last index of the array, and not throw an error, so it just removes the last bookmarked index.Fix by throwing an exception when
-1
is the found index. Also compares posts by IDs only which should be more reliable than comparing the entire object. Lastly, adds1
as the second argument to.splice
so it only deletes one item!Testing
Trust me bro