Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bookmarks #87

Closed
wants to merge 2 commits into from
Closed

Fix bookmarks #87

wants to merge 2 commits into from

Conversation

zachseidner1
Copy link

Overview

Fix BE bookmark deletion.

Right here the .splice method is being used with the indexOf operator. The issue is that indexOf returns -1 if the post is not found in the user’s saved posts. But splice will treat -1 as the last index of the array, and not throw an error, so it just removes the last bookmarked index.

Fix by throwing an exception when -1 is the found index. Also compares posts by IDs only which should be more reliable than comparing the entire object. Lastly, adds 1 as the second argument to .splice so it only deletes one item!

Testing

Trust me bro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing bookmark from the bookmarks page does not work
2 participants