Implement User Auth and Sessions #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,5 @@ | |||
| from django.urls import path, include | |||
| from django.views.decorators.http import require_POST | |||
There was a problem hiding this comment.
is this import used anywhere else? If not we can just delete it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Make new login route using user_session app with one-to-many between users and user_sessions to prevent being automatically logged out every 24 hours.
Changes Made
Added new login/logout routes in user/views using OAuth. Added user_sessions to track where users are logged in and to keep them logged in. Changed favorite_items to store item names instead of ids to allow different items to be treated the same across eateries. Also fixed minor bug in populate_eatery relating to error handling.
Test Coverage
Tested locally
Next Steps (delete if not applicable)
Needs to be joined with frontend to test login/logout