Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare menus #135

Closed
wants to merge 10 commits into from
Closed

Compare menus #135

wants to merge 10 commits into from

Conversation

oliviaxjiang
Copy link
Contributor

@oliviaxjiang oliviaxjiang commented Apr 28, 2024

Got compare menus to work on main page

  • adding floating action button
  • compare menus bottom sheet
  • the actual compare menus screen

some next steps

  • add in the sticky header for item category in the screen
  • refactor the bottom sheet logic into compare menus view model so we can have it everywhere (e.g. eatery details screen)

demo:

Screen.Recording.2024-04-28.at.3.12.54.PM.mov

@thisjustin123
Copy link
Contributor

Sorry for the late review! This definitely needs some touch ups, but of course do not work on this; we'll leave this to next semester.

I'll document the touch ups as GitHub issues. What we'll do is have this compare-menus branch live next semester as well, and then have someone make a new branch off compare-menus to merge into it to fix the issues.

@thisjustin123
Copy link
Contributor

Just opened #137 #138 #139 #140 #141 #142! Will revisit next semester.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants