issue63: add <fr> tag to entry-metadata.csv + bug fixes #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschare
added
bug
gschare
changed the title
7 tasks
|
OK. But see #70! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly a bug fix. Filenames in
entries/derivatives were not being formatted properly.Correct:
tl_p015r_1.txtWhat we have:
tl_15r1.txtThis was caused by the
clean_id()function inmanuscript.py, which makes it easier to work with the entry IDs in Python, but I forgot to reverse this change before writing the derivative. Should be fixed now.Run
update.pyto test this.And now for the actual issue: add
<fr>tag toutils.pyproperty dictionary, which should seamlessly add the property to theentry-metadata.csvderivative without affecting anything else.Again, run
update.pyto test this.