Minor bug fixes #305
Merged
Minor bug fixes #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
droberts-ctrlo
commented
Dec 12, 2023
droberts-ctrlo
commented
- Can now disable dropdowns
- Now have notes field in myaccount
- Can now disable dropdowns - Now have notes field in myaccount
droberts-ctrlo
added a commit
to droberts-ctrlo/GADS
that referenced
this pull request
Dec 19, 2023
* Addition of user notes to account requests (ctrlo#297) * Update formatting * Rebuild JS * Add accidentally-removed Fengari * Removed API code for not required endpoint * Move user notes field into same row as email address in user wizard * Do not populate read-only values during record clone * Fix datatables not adding click event on page or page-length change * Rebuild JS * Fix unable to clone with dependent fields * Fix for welcome email not being sent on approval of account (ctrlo#299) * Fix for welcome email not being sent on approval of account * Removed duplicate code * Changes as suggested * Change as suggested - User import will need testing within system - Changed Result User class as check for null is no longer required * Account request notes fix (ctrlo#303) * Account request notes fix There were 2 different fields within account request notes for "Notes" - it looks like one of them was added in error (as the "user" class has no "notes" field, and as such, I have removed the "extra" one and fixed the naming and settings of the field that was producing the error. * Changes as suggested * Fixed inability to remove title, department, team, and organisation * Minor bug fixes (ctrlo#305) * Minor bug fixes - Can now disable dropdowns - Now have notes field in myaccount * Removed ability for user to view own notes field * Change as suggested * Fix disabled search fields * Replace typeahead library --------- Co-authored-by: Andy Beverley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.