Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typeahead upgraded #292

Merged
merged 9 commits into from
Dec 18, 2023
Merged

Typeahead upgraded #292

merged 9 commits into from
Dec 18, 2023

Conversation

droberts-ctrlo
Copy link
Contributor

Redid commit as there were too many changes in the previous commit that were erroneous.

Redid commit as there were too many changes in the previous commit that were erroneous.
Copy link
Contributor Author

@droberts-ctrlo droberts-ctrlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is ready to merge, I have added comments where I feel appropriate. 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to removal of test directory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found that this works without issue, have removed lines to allow for removal of test directory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed neatening up after moving directory to lib directory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add CSS attributes rather than assuming class is defined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic mapper for AJAX requests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need other Typeahead components outside of testing and construction - only builder is needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very basic tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation needs below change to work with tests - this does not affect functionality

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I am now using TypeScript, a "fuller" configuration is required - this does not affect WebPack, just testing.

This was referenced Nov 30, 2023
@droberts-ctrlo
Copy link
Contributor Author

Tested on local system by OT - all appears working as expected

@abeverley abeverley merged commit fd46353 into ctrlo:uiux Dec 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants