-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelist for 2.3.18 #289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rebuild JS * Bump JS version * Fix for user editing not working correctly --------- Co-authored-by: Andy Beverley <[email protected]>
Need to work towards "common" fields working on all searches (i.e. ID, date created, etc.)
* Fix mandatory dropdowns in edit records incorrectly showing as incomplete * Rebuild JS --------- Co-authored-by: Andy Beverley <[email protected]>
* Fix mandatory dropdowns in edit records incorrectly showing as incomplete * Rebuild JS --------- Co-authored-by: Andy Beverley <[email protected]>
* Current UIUX (#4) * Fix mandatory dropdowns in edit records incorrectly showing as incomplete * Rebuild JS --------- Co-authored-by: Andy Beverley <[email protected]> * Removed odd code * Reporting fixes (ctrlo#277) - Added delete modal - Moved create report button to different place for consistency with other views - Changed the button from Reports to Download options when viewing records - Fixed overflow displaying off edge of screen for long report names - Removed ability to view/edit deleted reports - Fixed error on button code - Removed extra unneeded code - Created utility class for functions that are being used across a number of features (this could have been another request, but I keep having to make this file with most of what I'm doing every time, so it's better to push it now in my opinion) * Minor formatting updates * Revert incorrect code change * Make user fields searchable * Fix for region and org editing error (ctrlo#278) * Add notes field for field configuration * Adding notes field * Typeahead work * Typeahead complete Created "Builder" class and refactored code out into separate files * Package changes * Typeahead upgrade - Changed currently used typeahead library for one with better documentation (that is also more current) - Retrofitted to areas where old typeahead was used - Created abstraction for use within system - Typeahead class created - TypeaheadOptions interface created - TypeaheadBuilder class created Abstraction was done in order to make code easier to read and the possibility of controlling typeaheads as a single unit (thus keeping behaviour consistent). The builder was placed in order to make construction of a typeahead more verbose in order to mitigate errors within the configuration. * Update validation.js --------- Co-authored-by: Andy Beverley <[email protected]>
* Updated changelist * Added change to list * Corrected typo in last update date * Updated changes * More changes added * Reset change list Due to an update of "rules" changelists have changed - current changelist included
droberts-ctrlo
added a commit
to droberts-ctrlo/GADS
that referenced
this pull request
Jan 2, 2024
* Fix disabled search fields * Replace typeahead library * Changelist for 2.3.18 (ctrlo#289) * Rebuild JS and CSS * Updated typeahead with fix Typeahead query was not being sent correctly and was returning all results, rather than the filtered list, this has now been fixed * Rebuild JS --------- Co-authored-by: Andy Beverley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.