Allow running annotate for when the columns are frozen #1030
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: I noticed that it was fixed in a newer version 🤦 (PR #895). I left the PR open in case you want the tests.
In case where the columns are frozen, the gem 💥 when annotating the models:
The problem is that we're trying to modify the string when doing
column_type << ...
in lines:annotate_models/lib/annotate/annotate_models.rb
Lines 943 to 953 in 5d01c41
The fix
I duplicated the value if it's frozen 95327bd#diff-60ea710bcc08132bf411088124fcaa2b569a5ac493a5d364e0141f425afe2477R943