Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates scripts to process HEVC content #71

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Updates scripts to process HEVC content #71

wants to merge 3 commits into from

Conversation

nlsdvl
Copy link
Contributor

@nlsdvl nlsdvl commented Oct 25, 2024

Updates run-all.py and encode_dash.pyscripts:

  • now it takes the the mezzanine file list as an argument, the list is provided as a csv.
  • provide more flexibility in adding new columns to mezzanine csv and stream vector csv
  • signal cenc encryption through the csv files
  • fixes hardcoded cmf2 brand
  • fixes GOP size for hevc content
  • removes draft hevc splicing bash script as it can now be performed with the run-all script and specific csv configuration
  • fixes support for non square sar
  • adds --d/-dry-run option

replaces profiles/hevc.csv with profiles/chh1.csv & profiles/chd1.csv

rbouqueau
rbouqueau reviewed Oct 27, 2024
View reviewed changes
encode_dash.py Outdated
@@ -143,10 +144,10 @@ class AVCSD:

class AVCHD:
m_profile = "high"
m_level = "40"
m_level = "52"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, see https://docs.google.com/spreadsheets/d/1hxbqBdJEEdVIDEkpjZ8f5kvbat_9VGxwFP77AXA_0Ao/edit?gid=0#gid=0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I rolled back the changes, these were unintended. The PR currently focuses on the HEVC content generation. I'll take another look at AVC.

@nlsdvl nlsdvl mentioned this pull request Oct 29, 2024
Open
@nlsdvl
Copy link
Contributor Author

nlsdvl commented Oct 29, 2024

What's missing at this point:

  • run the updated scripts for AVC and re-run validation
  • remove upload/zip from run-all.py and document the new script that supports these functionnalities
  • update the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbouqueau rbouqueau rbouqueau left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlsdvl @rbouqueau