Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRR test suite fix #167

Merged
merged 2 commits into from
Jan 17, 2025
Merged

TRR test suite fix #167

merged 2 commits into from
Jan 17, 2025

Conversation

jlenain
Copy link
Collaborator

@jlenain jlenain commented Jan 16, 2025

Following #163 , the TRR test suite by Despina was broken. This PR fixes the few changes requested to make it work again.

@jlenain jlenain self-assigned this Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.43%. Comparing base (b306f30) to head (31f8dd7).
Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   40.76%   49.43%   +8.66%     
==========================================
  Files          65       63       -2     
  Lines        4452     4566     +114     
==========================================
+ Hits         1815     2257     +442     
+ Misses       2637     2309     -328     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlenain jlenain requested review from frnbrun and guillaumegrolleron and removed request for frnbrun January 16, 2025 13:43
@jlenain jlenain merged commit a7e0226 into cta-observatory:main Jan 17, 2025
11 checks passed
@jlenain jlenain deleted the trr-gui-fix branch January 17, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants