fix/suppress findings reported by Coverity

src/lib/cwe-mapper.cc

@@ -35,6 +35,7 @@ struct CweMap::Private {
     bool detectedByTool(Defect def, const char *tool) const;
 };
 
+// coverity[pass_by_value]
 bool CweMap::Private::detectedByTool(Defect def, const char *tool) const
 {
     // detect tool in case it is not explicitly specified

src/lib/filter.cc

@@ -111,7 +111,7 @@ void appendCtxLines(
         evt.event = "#";
         evt.msg = str.str();
         evt.verbosityLevel = /* not a key event */ 1;
-        pDst->push_back(evt);
+        pDst->push_back(std::move(evt));
     }
 }
 
@@ -202,7 +202,7 @@ bool DuplicateFilter::matchDef(const Defect &def)
     evt.fileName = MsgFilter::inst().filterPath(evt.fileName);
     evt.msg = MsgFilter::inst().filterMsg(evt.msg, def.checker);
 
-    return d->lookup.insert(evt)./* inserted */second;
+    return d->lookup.insert(std::move(evt))./* inserted */second;
 }
 
 

src/lib/instream.cc

@@ -19,8 +19,8 @@
 
 #include "instream.hh"
 
-InStream::InStream(std::string fileName, const bool silent):
-    fileName_(std::move(fileName)),
+InStream::InStream(const std::string &fileName, const bool silent):
+    fileName_(fileName),
     silent_(silent),
     str_((fileName_ == "-")
                 ? std::cin

src/lib/instream.hh

@@ -38,7 +38,7 @@ struct InFileException {
 
 class InStream {
     public:
-        InStream(std::string fileName, bool silent = false);
+        InStream(const std::string &fileName, bool silent = false);
         InStream(std::istringstream &str, bool silent = false);
         ~InStream() = default;
 

src/lib/parser-cov.cc

@@ -425,7 +425,7 @@ bool KeyEventDigger::guessKeyEvent(Defect *def)
         // no override for the checker -> match the lowered checker name
         std::string str(def->checker);
         boost::algorithm::to_lower(str);
-        defKeyEvent.insert(str);
+        defKeyEvent.insert(std::move(str));
     }
 
     // look for an explicitly defined key event

src/lib/parser-gcc.cc

@@ -549,13 +549,13 @@ bool BasicGccParser::getNext(Defect *pDef)
             case T_INC:
             case T_SCOPE:
                 done = this->exportAndReset(pDef);
-                defCurrent_.events.push_back(evt);
+                defCurrent_.events.push_back(std::move(evt));
                 break;
 
             case T_MSG:
                 done = this->exportAndReset(pDef);
                 defCurrent_.keyEventIdx = defCurrent_.events.size();
-                defCurrent_.events.push_back(evt);
+                defCurrent_.events.push_back(std::move(evt));
                 hasKeyEvent_ = true;
                 break;
 

src/lib/parser-json-cov.cc

@@ -89,4 +89,3 @@ bool CovTreeDecoder::readNode(Defect *def)
 
     return true;
 }
-

src/lib/parser-json-sarif.cc

@@ -202,7 +202,7 @@ static void sarifReadLocation(DefEvent *pEvt, const pt::ptree &loc)
         const auto uri = valueOf<std::string>(*al, "uri");
         if (!uri.empty())
             // read file name
-            pEvt->fileName = uri;
+            pEvt->fileName = std::move(uri);
     }
 
     const pt::ptree *reg;
@@ -247,7 +247,7 @@ static void sarifReadComments(Defect *pDef, const pt::ptree &relatedLocs)
             continue;
 
         evt.verbosityLevel = 1;
-        pDef->events.push_back(evt);
+        pDef->events.push_back(std::move(evt));
     }
 }
 

src/lib/parser-json-simple.cc

@@ -154,7 +154,7 @@ bool SimpleTreeDecoder::readNode(Defect *def)
         if (-1 == evt.verbosityLevel)
             verbosityLevelNeedsInit = true;
 
-        evtListDst.push_back(evt);
+        evtListDst.push_back(std::move(evt));
     }
 
     // read "defect_id", "cwe", and "function" if available

src/lib/parser-json-zap.cc

@@ -141,7 +141,7 @@ void ZapTreeDecoder::readScanProps(
 {
     const auto version = valueOf<std::string>(*root, "@version");
     if (!version.empty())
-        (*pDst)["analyzer-version-owasp-zap"] = version;
+        (*pDst)["analyzer-version-owasp-zap"] = std::move(version);
 
     d->timeStamp = valueOf<std::string>(*root, "@generated");
 }

src/lib/parser-xml-valgrind.cc

@@ -58,7 +58,7 @@ bool /* continue */ skipLdArgs(
             goto skip_arg;
 
         // record path of the real binary being executed
-        *pExe = argVal;
+        *pExe = std::move(argVal);
         ++(*pIt);
         return /* continue */ (itEnd != *pIt);
 
@@ -224,7 +224,7 @@ void readStack(Defect *pDef, const pt::ptree &stackNode)
         }
 
         // finally push the "note" event
-        pDef->events.push_back(noteEvt);
+        pDef->events.push_back(std::move(noteEvt));
     }
 }