Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce the csdiff-static subpackage #196

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Conversation

kdudka
Copy link
Member

@kdudka kdudka commented Jul 23, 2024

... with a statically linked csgrep-static executable needed for context embedding in legacy build environments.

@kdudka kdudka self-assigned this Jul 23, 2024
@kdudka kdudka force-pushed the csgrep-static branch 3 times, most recently from 3a84c4b to 669a61c Compare July 24, 2024 11:44
kdudka added a commit to kdudka/logging-vector that referenced this pull request Jul 25, 2024
@kdudka kdudka marked this pull request as ready for review July 25, 2024 20:24
@kdudka kdudka requested a review from lzaoral July 25, 2024 20:24
@kdudka
Copy link
Member Author

kdudka commented Jul 25, 2024

The csdiff-static subpackage has been experimentally used in a Konflux CI task for source code context embedding into SAST scanning results produced by GCC Analyzer: ralphbean/logging-vector@d5abfdf

kdudka added a commit to kdudka/logging-vector that referenced this pull request Jul 25, 2024
make-srpm.sh Show resolved Hide resolved
Copy link
Member

@siteshwar siteshwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers from my side.

kdudka added 3 commits August 2, 2024 14:36
According to make documentation, the `target_link_libraries()` command
should be preferred whenever possible.

Related: csutils#196
If set to ON, a statically linked `csgrep-static` executable is built
and installed to the `libexec` directory.  It is needed for context
embedding in legacy build environments.

Related: csutils#196
... with a statically linked csgrep-static executable needed for context
embedding in legacy build environments.

Closes: csutils#196
@kdudka
Copy link
Member Author

kdudka commented Aug 2, 2024

@siteshwar Thanks for review!

@kdudka kdudka merged commit 52330d3 into csutils:main Aug 2, 2024
7 of 27 checks passed
@kdudka kdudka deleted the csgrep-static branch August 2, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants