Upgrade to postcss 8, update dependencies #15
Conversation
|
@bjentsch thanks a lot for taking the time to do this. I'll take a closer look, looks great at first sight! Nice work! It might take some time as I'm not familiar with this plugin (yet) Will keep you updated! |
|
@bjentsch thanks for your patience with this! I'm keen to merge this and also to release it. That said I'd love to keep parity on what we've done for the rest of the plugins as much as possible. That means, we'd be better without prettier (as you kind of hinted) but eslint enforcing it. I'll set up GitHub actions for this plugin once it's merged. We will also remove source maps as we haven't seen them useful in any reports. Would you want to do this as part of the PR or would you like us to do that after merging it? Thanks a lot again! |
|
Hey @Antonio-Laguna, never mind, I'll remove the As for the other changes (eslint, source maps) I'd be glad if you could do it afterwards. |
|
Sounds like a plan! |
|
Removed the |
|
Nice, thanks a lot! |
|
@bjentsch this got published as 4.0.0 |
Hi folks
As mentioned in #13 and in postcss/postcss-nested#139 (comment), this library should be upgraded to postcss@8.
I tried to keep the invasiveness of the changes at a minimum to make sure to port the exact functionality of the plugin. The only real changes are the ones suggested in the PostCSS 8 upgrade guide, such as using the updated basic API (
OnceExit) and declaringmodule.exports.postcss = true;.For code style's sake, I tested prettier on the project and thought it would make a nice addition, hence the
.prettierrcfile. I didn't add a hard dependency here though, and I kept the original formatting for the project for this PR. I don't have a strong opinion on this though, and if you don't like prettier, I'm open to removing the.prettierrcfile again.Apart from that, I bumped all the other dependencies to their respective latest versions and updated the README.
Let me know if this PR is any good 🤗