-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Waitlisting Feature Dev #506
Initial Waitlisting Feature Dev #506
Conversation
…ed functionality for when students drop will auto call waitlist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't taken too close of a look at the implementation yet, but just wanted to point out some things I noticed; left some comments about them.
In addition, try to at least get the pytests and the pre-commit check to pass (I don't believe that they'll automatically run on this PR since it's not targeting master, so you may need to manually re-run tests on the PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests seem to be failing according to the automated tests. Could changing section view have broken other tests? If not, I'm not sure if these automated tests are valid.
pre-commit is failing due to the
Seems like you need to make sure that |
Finished initial backend feature for waitlisting.
Not implemented yet: