Add a new RPC and Cap to advertise the client details #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
force-pushed
the
client-to-fence
branch
4 times, most recently
from
d8df023 to
66639b5
Compare
nixpanic
requested changes
Oct 31, 2024
identity/README.md
Outdated
| @@ -234,6 +234,13 @@ message Capability { | |||
| // plugin can invoke RPCs that require access to the storage system, | |||
| // similar to the CSI Controller (provisioner). | |||
| NETWORK_FENCE = 1; | |||
|
|
|||
| // GET_CLIENTS_TO_FENCE indicates that the CSI-driver provides RPCs for a | |||
| // GET_CLIENTS_TO_FENCE operation to fet the clients to fence. | |||
There was a problem hiding this comment.
typo fet
Also a typo cline in the commit message.
fence/README.md
Outdated
| @@ -66,6 +66,11 @@ service FenceController { | |||
| // ListClusterFence RPC call to provide a list of blocklisted/fenced clients. | |||
| rpc ListClusterFence(ListClusterFenceRequest) | |||
| returns (ListClusterFenceResponse){} | |||
|
|
|||
| // GetFenceClients RPC calls to get the clients information that needs | |||
| // to be fenced. | |||
There was a problem hiding this comment.
Maybe .. get the client information to use in a FenceClusterNetwork or UnfenceClusterNetwork RPC.
Madhu-1
force-pushed
the
client-to-fence
branch
from
66639b5 to
bae5310
Compare
nixpanic
previously approved these changes
Oct 31, 2024
| // GET_CLIENTS_TO_FENCE operation to get the clients to fence. | ||
| // The presence of this capability determines whether the CSI-Addons CO | ||
| // plugin can invoke RPCs that require access to the storage system, | ||
| // similar to the CSI Controller (provisioner). |
There was a problem hiding this comment.
Thanks for fixing the typos, however there is now clinets in the commit description 😆
added a GET_CLIENTS_TO_FENCE so that the plugins can register with this caps to advertise that they support publishing the metadata like identifier and the cluster IP addresses of the clients for the fence operations. Signed-off-by: Madhu Rajanna <[email protected]>
Adding a RPC to get the local client details which includes the id and the local ip addresses for fencing. The ID can be anything that can be used as an identifier about the client address. For example the ID can be the cephcluster UUID and the ip addressed/cidr is the local client addresses used to connect to the ceph cluster, The ceph is an example/representation here. Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
force-pushed
the
client-to-fence
branch
from
bae5310 to
cf8a5d3
Compare
mergify
bot
dismissed
nixpanic’s stale review
Pull request has been modified.
nixpanic
approved these changes
Oct 31, 2024
Madhu-1
requested review from
black-dragon74,
yati1998,
iPraveenParihar and
Rakshith-R
yati1998
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a GET_CLIENTS_TO_FENCE so that the plugins can register with these caps to advertise that they support publishing the metadata like identifier and the cluster IP addresses of the clone cline for the fence operations.
Adding an RPC to get the local client details which includes the id and the local IP addresses for fencing. The ID can be anything that can be used as an identifier of the client address. For example, the ID can be the cephcluster UUID and the ip address/cidr is the local client address used to connect to the ceph cluster, The ceph is an example/representation here.