Skip to content

Initialize HPWHsim presets from embedded CBOR #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

spahrenk
Copy link
Contributor

@spahrenk spahrenk commented Jun 4, 2025

The initialization of HPWH models is changed to load from a hpwh_data_model representation embedded within the HPWHsim source code in CBOR format, rather than via separate code-based setup for each model. These representations were themselves generated from the original code-based setups, which were converted to JSON, then embedded as CBOR. These JSON model files are included with the HPWHsim repository at test/model_json. The embedded representations are generated from these JSON files during the CMake build. Generation is done from python using the uv package manager, which is installed during build.

@spahrenk spahrenk self-assigned this Jun 4, 2025
@spahrenk spahrenk marked this pull request as draft June 4, 2025 19:41
@spahrenk spahrenk requested a review from nealkruis June 9, 2025 22:11
@spahrenk spahrenk marked this pull request as ready for review June 13, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant