Skip to content

Allow UEF input for Heat Pump Water Heaters #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 16, 2025
Merged

Allow UEF input for Heat Pump Water Heaters #537

merged 8 commits into from
Apr 16, 2025

Conversation

nealkruis
Copy link
Contributor

@nealkruis nealkruis commented Mar 31, 2025

Description

Uses whUEF to adjust the HPWH compressor performance map such that the calculated 24 hour test UEF result matches the value input by the user. Needs further testing, and we likely need to impose limits on the range of UEF's we allow to input.

Author Progress Checklist:

  • Open draft pull request
    • Make title clearly understandable in a standalone change log context
    • Assign yourself the issue
    • Add at least one label (enhancement, bug, or maintenance)
    • Link the issue(s) addressed by this PR (under "Development" in the sidebar menu)
  • Make code changes (if you haven't already)
  • Self-review of code
    • My code follows the style guidelines of this project
    • I have added comments to my code, particularly in hard-to-understand areas
    • I have only committed the necessary changes for this fix or feature
    • I have made corresponding changes to the documentation
    • My changes generate no new warnings
    • I have ensured that my fix is effective or that my feature works as intended by:
      • exercising the code changes in the test framework, and/or
      • manually verifying the changes (as explained in the the pull request description above)
    • My changes pass all local tests
    • My changes successfully passes CI checks
    • Add any unit test for proof and documentation.
    • Merge in main branch and address resulting conflicts and/or test failures.
  • Move pull request out of draft mode and assign reviewers
  • Iterate with reviewers until all changes are approved
    • Make changes in response to reviewer comments
    • Merge in main branch and address resulting conflicts and/or test failures.
    • Re-request review in GitHub

Reviewer Checklist:

  • Read the pull request description
  • Perform a code review on GitHub
  • Confirm all CI checks pass and there are no build warnings
  • Pull, build, and run automated tests locally
  • Perform manual tests of the fix or feature locally
  • Add any review comments, if applicable
  • Submit review in GitHub as either
    • Request changes, or
    • Approve
  • Iterate with author until all changes are approved

@nealkruis nealkruis changed the title Make generic UEF water heater. Allow UEF input for Heat Pump Water Heaters Mar 31, 2025
@nealkruis nealkruis self-assigned this Mar 31, 2025
@spahrenk
Copy link
Contributor

Looks fine. DHWHEATER_UEF seems to have existed previously, and may have been repurposed.

src/dhwcalc.cpp Outdated
// Adjust values to match UEF if provided
if (IsSet(DHWHEATER_UEF))
{
// TODO: Turn off warnings in HPWH courier
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there Courier loose ends that need attentions?

Copy link
Contributor

@chipbarnaby chipbarnaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Courier hookup complete for HPWH?

See comment in dhwcalc.cpp

@nealkruis
Copy link
Contributor Author

Courier is hooked up to HPWHsim, but we likely want to follow up on some of the loose ends identified when we added it to performance maps. We can follow up with those later if needed. In the meantime, we can get this version over to Scott for testing?

@nealkruis nealkruis merged commit e5567b7 into main Apr 16, 2025
4 checks passed
@nealkruis nealkruis deleted the generic-uef branch April 16, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants