-
Notifications
You must be signed in to change notification settings - Fork 5
Allow UEF input for Heat Pump Water Heaters #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks fine. DHWHEATER_UEF seems to have existed previously, and may have been repurposed. |
src/dhwcalc.cpp
Outdated
// Adjust values to match UEF if provided | ||
if (IsSet(DHWHEATER_UEF)) | ||
{ | ||
// TODO: Turn off warnings in HPWH courier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there Courier loose ends that need attentions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is Courier hookup complete for HPWH?
See comment in dhwcalc.cpp
Courier is hooked up to HPWHsim, but we likely want to follow up on some of the loose ends identified when we added it to performance maps. We can follow up with those later if needed. In the meantime, we can get this version over to Scott for testing? |
Description
Uses
whUEF
to adjust the HPWH compressor performance map such that the calculated 24 hour test UEF result matches the value input by the user. Needs further testing, and we likely need to impose limits on the range of UEF's we allow to input.Author Progress Checklist:
Reviewer Checklist: