Repair HPWHsim energy balancing

[spahrenk]

Description

• Fixes energy balancing errors that occur in HPWHsim. Five distinct errors are identified in the related HPWHsim PR: Balance energy bigladder/HPWHsim#184. These generate the message "HPWH energy balance error..." in cse. Following these changes, I am not able to find any occurrences of this message.
• Several test reference report files are replaced in this branch. I was not able to inspect every regression difference that resulted, and many of them seem to be quite small dhw changes. However, some seem large enough to cause concern, and may merit further investigation.
• One energy-balance issue resolved here appears to have occurred because the "extra heat" methods in HPWHsim do not retain "leftover" heat, which is used for other heat sources to hinder exceeding the setpoint temperature. But cse records the full amount of energy provided in each step, so some heat was being rejected in HPWHsim, which was not reported back to cse. These changes cause the full heat specified by cse to be supplied to the tank. (Another branch improves the "extra" heat calculation, but does not change this energy tracking.)
• A function isEnergyBalanced is added to HPWHsim, but is only configured to check for energy errors across a single simulation step, whereas cse compares energy differences hourly (I think.) But this could be developed further, if needed.

Author Progress Checklist:

• Open draft pull request
  • Make title clearly understandable in a standalone change log context
  • Assign yourself the issue
  • Add at least one label (enhancement, bug, or maintenance)
  • Link the issue(s) addressed by this PR (under "Development" in the sidebar menu)
• Make code changes (if you haven't already)
• Self-review of code
  • My code follows the style guidelines of this project
  • I have added comments to my code, particularly in hard-to-understand areas
  • I have only committed the necessary changes for this fix or feature
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have ensured that my fix is effective or that my feature works as intended by:
    • exercising the code changes in the test framework, and/or
    • manually verifying the changes (as explained in the the pull request description above)
  • My changes pass all local tests
  • My changes successfully passes CI checks
  • Add any unit test for proof and documentation.
  • Merge in main branch and address resulting conflicts and/or test failures.
• Move pull request out of draft mode and assign reviewers
• [] Iterate with reviewers until all changes are approved
  • Make changes in response to reviewer comments
  • Merge in main branch and address resulting conflicts and/or test failures.
  • Re-request review in GitHub

Reviewer Checklist:

• Read the pull request description
• Perform a code review on GitHub
• Confirm all CI checks pass and there are no build warnings
• Pull, build, and run automated tests locally
• Perform manual tests of the fix or feature locally
• Add any review comments, if applicable
• Submit review in GitHub as either
  • Request changes, or
  • Approve
• Iterate with author until all changes are approved

[chipbarnaby]

As I understand this PR, there are no changes in CSE; we're just using an updated HPWHSIM branch. Right?

Based on a quick scan, it looks like all the test file changes are minimal EXCEPT dhwloop32U.cse. MtrElecLoop values change 5 - 10 % in some cases. This needs to be investigated.

There may be other large changes, it is hard to see them in github's diff display.

I will write some stuff in slack about how I review test diffs.

[nealkruis]

The dhwloop32U.cse output provides some really helpful energy balance reports. The energy balance errors in the primary tank before this change were on the order of magnitude of the change in the loop heater energy. My hypothesis is that the error in the prior results was causing lower heating requirements in the primary heater that were being made up by the loop heater.

[spahrenk]

Unit conversions declared constexp in header. Document and conform addExtraHeatAboveNode and addHeatAboveNode. Move latter from HeatSource to HPWH.