Skip to content

Add option to update REP files during diff.bat #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

galanCA
Copy link
Contributor

@galanCA galanCA commented Jan 12, 2022

Description

The purpose of this feature is to check the difference between REP files and update them in a single command. The expected behavior after running diff.bat is:

  • After adding the /U flag diff.bat /U
  • Checks all the files inside beyond compare.
  • A prompt will appear asking the user if they want to update the REP files.
  • After saying yes a second prompt will appear to make sure the user knows the consequences.

The author manually tested the behavior for all the if statements. Also makes sure diff.bat is generated properly.

Author Progress Checklist:

  • Open draft pull request
    • Make title clearly understandable in a standalone change log context
    • Assign yourself the issue
    • Add at least one label
  • Make code changes (if you haven't already)
  • Self-review of code
    • My code follows the style guidelines of this project
    • I have performed a self-review of my code
    • I have added comments to my code, particularly in hard-to-understand areas
    • I have only committed the necessary changes for this fix or feature
    • I have made corresponding changes to the documentation
    • My changes generate no new warnings
    • I have ensured that my fix is effective or that my feature works as intended by:
      • exercising the code changes in the test framework, and/or
      • manually verifying the changes (as explained in the the pull request description above)
    • My changes pass all local tests
    • My changes successfully passes CI checks
  • Move pull request out of draft mode and assign reviewers
  • Iterate with reviewers until all changes are approved
    • Make changes in response to reviewer comments
    • Re-request review in GitHub

Reviewer Checklist:

  • Read the pull request description
  • Perform a code review on GitHub
  • Confirm all CI checks pass and there are no build warnings
  • Pull, build, and run automated tests locally
  • Perform manual tests of the fix or feature locally
  • Add any review comments, if applicable
  • Submit review in GitHub as either
    • Request changes, or
    • Approve
  • Iterate with author until all changes are approved
  • If you are the last reviewer to approve, merge the pull request and delete the branch

@galanCA galanCA self-assigned this Jan 12, 2022
@galanCA galanCA linked an issue Jan 12, 2022 that may be closed by this pull request
@galanCA
Copy link
Contributor Author

galanCA commented Feb 7, 2022

The test should go as follows: If there are no diffs to check. It should exit gracefully. But if there are one or more tests then after reviewing them it will prompt if you want to update them. If N then it will exit the script. If Y then it will ask you one more time to double-check. If yes again it will call update.bat and update the files.

@galanCA galanCA marked this pull request as ready for review February 7, 2022 18:21
@galanCA galanCA requested a review from nealkruis February 7, 2022 18:21
@galanCA
Copy link
Contributor Author

galanCA commented Jun 27, 2022

Add a flag to get the option to ask to update the REP files

@nealkruis nealkruis requested a review from tanaya-mankad July 13, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional update step to diffing tests
1 participant