Skip to content

Add ability to simulate ASHRAE 205 representations #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

Conversation

nealkruis
Copy link
Contributor

Description

Currently limited to RS0004 (Unitary Air Conditioning). Added new test file 205Test.cse.

Author Progress Checklist:

  • Open draft pull request
    • Make title clearly understandable in a standalone change log context
    • Assign yourself the issue
    • Add at least one label
  • Make code changes (if you haven't already)
  • Self-review of code
    • My code follows the style guidelines of this project
    • I have performed a self-review of my code
    • I have added comments to my code, particularly in hard-to-understand areas
    • I have only committed the necessary changes for this fix or feature
    • I have made corresponding changes to the documentation
    • My changes generate no new warnings
    • I have ensured that my fix is effective or that my feature works as intended by:
      • exercising the code changes in the test framework, and/or
      • manually verifying the changes (as explained in the the pull request description above)
    • My changes pass all local tests
    • My changes successfully passes CI checks
  • Move pull request out of draft mode and assign reviewers
  • Iterate with reviewers until all changes are approved
    • Make changes in response to reviewer comments
    • Re-request review in GitHub

Reviewer Checklist:

  • Read the pull request description
  • Perform a code review on GitHub
  • Confirm all CI checks pass and there are no build warnings
  • Pull, build, and run automated tests locally
  • Perform manual tests of the fix or feature locally
  • Add any review comments, if applicable
  • Submit review in GitHub as either
    • Request changes, or
    • Approve
  • Iterate with author until all changes are approved
  • If you are the last reviewer to approve, merge the pull request and delete the branch

@nealkruis
Copy link
Contributor Author

@chipbarnaby, the test failures here are very puzzling to me. Here are the files that are failing:

	 34 - 1zattic.Regression (Failed)
	 36 - 1ZKiva.Regression (Failed)
	 38 - 2zattic.Regression (Failed)
	 48 - ashp_dfng.Regression (Failed)
	 68 - dhw_zone.Regression (Failed)

All of these except 48 have 0.01 differences in Nair in a handful of subhours. Here's the example report (I'm not sure what report this is part of):

================
Wed 10-Jul  hr=2 subhr=2
----------------

Z1 W:  mwIG=0.000  mwInf=0.000  mwAN=10.742  mwDuctLk=0.000  mwSys=0.000
     tdb=73.48  airX=3.673  dryAirMass=248.34  XLGain=0.00  W=0.011816  twb=61.89  rh=0.5489
Z1 CZ: anMCp/T[ 0]=74.75/5115.2  anMCp/T[ 1]=222.18/15204.4  ventUt=1
     Nair=2266427.52  Dair=30835.51  Nrad=108047.82  Drad=1470.49  CX=488.28  airX=3.673
     TH=64.88  TD=68.00  TC=74.12  qhCap=20000  qcCap=-34000
     ta=73.48  tr=73.48  qIzSh=-1121  fvent=1.000  pz0=-0.0034  qsHvac=0
Attic W:  mwIG=0.000  mwInf=0.000  mwAN=5.630  mwDuctLk=0.000  mwSys=0.000
     tdb=73.90  airX=9.748  dryAirMass=48.96  XLGain=0.00  W=0.011805  twb=62.00  rh=0.5406
Attic UZ: anMCp/T[ 0]=115.81/8191.6  anMCp/T[ 1]=116.25/8224.4  ventUt=0
     Nair=72568.96  Dair=1007.94  Nrad=70349.63  Drad=885.67  CX=569.44  airX=9.748
     ta=73.90  tr=77.27  qIzSh=-366  fvent=1.000  pz0=-0.0072  qsHvac=0

Test 48 is probably worth a call to go over. The test file has 5 separate runs where the meter reports for each run are identical, but the UDT reports have diffs for all except the last run.

Copy link
Contributor

@chipbarnaby chipbarnaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the ashp_dfng changes are suspicious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants