Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change year_of_admission to year_of_curiculum in gradebook #799

Merged
merged 6 commits into from
Jan 15, 2024

Conversation

Dmi4er4
Copy link
Collaborator

@Dmi4er4 Dmi4er4 commented Jan 15, 2024

Checklist:

  • I have performed a self-review of my own code:
    • Good naming: make sure you would understand your code if you read it a few months from now.
    • No common performance issues (e.g. N + 1 problem)
    • Unrelated code has been removed (unused imports, print statements, unrelated template context variables, commented code, etc)
    • I have commented my code, particularly in hard-to-understand areas
  • I understand that short PRs lead to higher-quality code and faster delivery of features.
  • Linear history: my code has been rebased on the most recent commit in the master branch before opening PR
  • I have followed conventional commits specification for PR title
  • I have referenced YouTrack issue in the PR description for easy access
  • I have added tests that prove my code works

@Dmi4er4 Dmi4er4 requested a review from atolstikov January 15, 2024 10:42
@atolstikov atolstikov merged commit abe7482 into cscenter:master Jan 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants