Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tab to fix make #174

Closed
wants to merge 1 commit into from
Closed

Add missing tab to fix make #174

wants to merge 1 commit into from

Conversation

ivanovmg
Copy link

This change fixes the problem #173
Added the missing tab.

@cmlsharp
Copy link
Contributor

cmlsharp commented Jul 25, 2019

Thanks for the PR! Unfortunately, this change breaks the Makefile on Linux (in fact, it yields the same behavior noted in #173). I'm unsure why you are experiencing this issue on Windows. Will explore this a bit more.

@cmlsharp
Copy link
Contributor

After some experimentation I have a better idea what is going on here. By adding this tab, you have essentially just disabled the all target. When you run make by itself, it defaults to the top target in the file. Since all has been disabled, it defaults to the next target $(LIBS). I am at present unsure why you are getting the issue mentioned in #174. Just to be sure, would you try removing this tab from your local copy, running make clean and then make?

@cmlsharp cmlsharp closed this Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants