Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bg color controls #112

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Added bg color controls #112

merged 3 commits into from
Mar 5, 2024

Conversation

BraydenThompson
Copy link
Collaborator

Closes #101

Discussion

Hooked in functionality of color picker widget into the ipyvolume graph. After researching how to change the transfer function colors on the volume graph, I found that there is no natively supported way to change the colors in Ipyvolume. In their repository, there are attempts to implement improved transfer functions. See: here, here and here, but they seemingly haven't gone anywhere.

A recommended solution here involves modifying the rgba image output of the graph, and rendering that to screen, which seems like overkill for this task.

Overall, it seems unlikely that we can change the colors without modifying ipyvolume's code to some extent, which is a larger discussion we will have at our next meeting.

Testing

  • Run build.sh and make sure new dependencies install in .venv
  • Open up the notebook (make sure using the .venv Python kernel)
  • Execute the cells, update the color in the color picker, and re-run the display cell, making sure the background color updates.

Copy link
Collaborator

@matthew-oberg matthew-oberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and working.

@BraydenThompson BraydenThompson merged commit 76eb421 into main Mar 5, 2024
1 check passed
@BraydenThompson BraydenThompson deleted the task101 branch March 5, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change color of point cloud
3 participants