-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assignment 1 Submission aburke921 (Ashley Burke) #112
Open
aburke921
wants to merge
10
commits into
cs4241-21a:main
Choose a base branch
from
aburke921:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an Image of my self that will be used in the top bar of the webpage, as well as a screenshot of the color pallet used for the webpage. This screenshot will be displayed in the README.md file.
According to the prof, the line `file = content` is a bug and should be removed.
All of the requirements were met for assignement 1 and are incorporated into the html.index file that is being updated now. There is one bug that I was able to find but don't have time to fix yet; when the user clicks no "Previous Courses" or "Experience", the popup circle containing the information is not centered in the screen. Additionally for some reason, the formatting of the "Previous Courses" inside the list view is not formatting as it would be expected. This may be fixed after the submission, time permitting.
The README.md, no long has the directions of the assignment, but now only includes a description of the achievements that were made when designing the webpage.
Changed the author name to be my own.
Changed from .JPG to .png because when uploaded to glitch, the .JPG was not able to be read; the .png used for the screenshot of the color wheel was able to be read.
edited the name to fit the grading rubric. I fixed the name to include my GitHub username.
Changed the img tag to contain the link of the image in the glitch assets folder.
Centered the circle containing the "Experience" and "Previous Courses" info. Previous courses list still has some work to do.
changed image url to match the new glitch page with the centered circle popup.
aburke921
changed the title
Assignment 1 Submission aburke921
Assignment 1 Submission aburke921 (Ashley Burke)
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.