-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add token scope field to gateway authenticate requests #123
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| // Copyright 2018-2019 CERN | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
| // In applying this license, CERN does not waive the privileges and immunities | ||
| // granted to it by virtue of its status as an Intergovernmental Organization | ||
| // or submit itself to any jurisdiction. | ||
|
|
||
| syntax = "proto3"; | ||
|
|
||
| package cs3.auth.provider.v1beta1; | ||
|
|
||
| option csharp_namespace = "Cs3.Auth.Provider.V1Beta1"; | ||
| option go_package = "providerv1beta1"; | ||
| option java_multiple_files = true; | ||
| option java_outer_classname = "ResourcesProto"; | ||
| option java_package = "com.cs3.auth.provider.v1beta1"; | ||
| option objc_class_prefix = "CAP"; | ||
| option php_namespace = "Cs3\\Auth\\Provider\\V1Beta1"; | ||
|
|
||
| import "cs3/types/v1beta1/types.proto"; | ||
|
|
||
| // Scope defines role-based permissions for various resources. | ||
| message Scope { | ||
| // REQUIRED. | ||
| // The resource embedded in the request of a particular method. It depends on | ||
| // the method, hence is left as opaque. | ||
| cs3.types.v1beta1.OpaqueEntry resource = 1; | ||
| // REQUIRED. | ||
| // The role associated with the resource. | ||
| Role role = 2; | ||
| } | ||
|
|
||
| // The role associated with the scope. | ||
| enum Role { | ||
| // Used for invalid roles | ||
| ROLE_INVALID = 0; | ||
| // Grants owner permissions on a resource | ||
| ROLE_OWNER = 1; | ||
| // Provides backwards compatibility | ||
| ROLE_LEGACY = 2; | ||
| // Grants non-editor role on a resource | ||
| ROLE_VIEWER = 3; | ||
| // Grants editor permission on a resource, including folders | ||
| ROLE_EDITOR = 4; | ||
| // Grants editor permission on a single file | ||
| ROLE_FILE_EDITOR = 5; | ||
| // Grants co-owner permissions on a resource | ||
| ROLE_COOWNER = 6; | ||
| // Role with only write permission can use InitiateFileUpload, nothing else | ||
| ROLE_UPLOADER = 7; | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that
resourcehere is an opaque object, not a storage reference. That's because we need to allow a variety of requests, not just limited to the storage provider. Eg,GetPublicShare ref:<token:"XRKWRTefdZPPVVo">There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense, a valid concern. Thanks for pointing it out 👍