Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support signature authentication for public links #118

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Mar 23, 2021

Deprecated the changes from #113
and enhanced the api to support signature based authentication for
public links.

@ishank011
Copy link
Contributor

The signature should ideally be returned when calling ListPublicShares as well. Would it make more sense to add it to the PublicShare message?

@C0rby
Copy link
Contributor Author

C0rby commented Mar 24, 2021

The signature should ideally be returned when calling ListPublicShares as well. Would it make more sense to add it to the PublicShare message?

True if we want to introduce this signature authentication in general. I had just had the owncloud public shares in mind which only need the signatures after calling GetPublicShareByToken but I can add that to ListPublicShares.

@C0rby
Copy link
Contributor Author

C0rby commented Mar 24, 2021

Should we always include the signature or should it be controllable via a flag?

@ishank011
Copy link
Contributor

I would prefer that the sign be a part of the PublicShare message. The flag looks fine. Can you just remove the deprecated field altogether? We don't have a lot of clients so breaking changes should be fine at this stage

Deprecated the changes from cs3org#113
and enhanced the api to support signature based authentication for
public links.
@ishank011 ishank011 merged commit aa7f446 into cs3org:master Mar 25, 2021
@C0rby C0rby deleted the public-link-signature branch March 25, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants