Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short and sweet lint that addresses this issue by flagging any calls to
bincode::deserialize()
(resolving to a type implementing Sysvar trait) and advising user to usefrom_account_info()
instead (the way they should do it).There could be another variation of this lint that performs a key check. This variation has the trade-off that it will avoid false positives, but if the key check is not robust enough, it will leave out some cases we want to catch.
There are many ways to perform a key check. Referencing the key field directly, calling key() (from anchor), unsigned_key(), to name a few. Then there could be != or == checks. With this in mind, I think it's difficult to implement a good key check, and better to just recommend using
from_account_info()
.